lkml.org 
[lkml]   [2018]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.18 036/136] powerpc/kdump: Handle crashkernel memory reservation failure
    Date
    From: Hari Bathini <hbathini@linux.ibm.com>

    [ Upstream commit 8950329c4a64c6d3ca0bc34711a1afbd9ce05657 ]

    Memory reservation for crashkernel could fail if there are holes around
    kdump kernel offset (128M). Fail gracefully in such cases and print an
    error message.

    Signed-off-by: Hari Bathini <hbathini@linux.ibm.com>
    Tested-by: David Gibson <dgibson@redhat.com>
    Reviewed-by: Dave Young <dyoung@redhat.com>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    arch/powerpc/kernel/machine_kexec.c | 7 ++++++-
    1 file changed, 6 insertions(+), 1 deletion(-)

    diff --git a/arch/powerpc/kernel/machine_kexec.c b/arch/powerpc/kernel/machine_kexec.c
    index 936c7e2d421e..b53401334e81 100644
    --- a/arch/powerpc/kernel/machine_kexec.c
    +++ b/arch/powerpc/kernel/machine_kexec.c
    @@ -188,7 +188,12 @@ void __init reserve_crashkernel(void)
    (unsigned long)(crashk_res.start >> 20),
    (unsigned long)(memblock_phys_mem_size() >> 20));

    - memblock_reserve(crashk_res.start, crash_size);
    + if (!memblock_is_region_memory(crashk_res.start, crash_size) ||
    + memblock_reserve(crashk_res.start, crash_size)) {
    + pr_err("Failed to reserve memory for crashkernel!\n");
    + crashk_res.start = crashk_res.end = 0;
    + return;
    + }
    }

    int overlaps_crashkernel(unsigned long start, unsigned long size)
    --
    2.17.1
    \
     
     \ /
      Last update: 2018-09-17 05:36    [W:2.100 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site