lkml.org 
[lkml]   [2018]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.14 04/87] vmci: type promotion bug in qp_host_get_user_memory()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 7fb2fd4e25fc1fb10dcb30b5519de257cfeae84c ]

    The problem is that if get_user_pages_fast() fails and returns a
    negative error code, it gets type promoted to a high positive value and
    treated as a success.

    Fixes: 06164d2b72aa ("VMCI: queue pairs implementation.")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/misc/vmw_vmci/vmci_queue_pair.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/misc/vmw_vmci/vmci_queue_pair.c b/drivers/misc/vmw_vmci/vmci_queue_pair.c
    index 8af5c2672f71..b4570d5c1fe7 100644
    --- a/drivers/misc/vmw_vmci/vmci_queue_pair.c
    +++ b/drivers/misc/vmw_vmci/vmci_queue_pair.c
    @@ -755,7 +755,7 @@ static int qp_host_get_user_memory(u64 produce_uva,
    retval = get_user_pages_fast((uintptr_t) produce_uva,
    produce_q->kernel_if->num_pages, 1,
    produce_q->kernel_if->u.h.header_page);
    - if (retval < produce_q->kernel_if->num_pages) {
    + if (retval < (int)produce_q->kernel_if->num_pages) {
    pr_debug("get_user_pages_fast(produce) failed (retval=%d)",
    retval);
    qp_release_pages(produce_q->kernel_if->u.h.header_page,
    @@ -767,7 +767,7 @@ static int qp_host_get_user_memory(u64 produce_uva,
    retval = get_user_pages_fast((uintptr_t) consume_uva,
    consume_q->kernel_if->num_pages, 1,
    consume_q->kernel_if->u.h.header_page);
    - if (retval < consume_q->kernel_if->num_pages) {
    + if (retval < (int)consume_q->kernel_if->num_pages) {
    pr_debug("get_user_pages_fast(consume) failed (retval=%d)",
    retval);
    qp_release_pages(consume_q->kernel_if->u.h.header_page,
    --
    2.17.1
    \
     
     \ /
      Last update: 2018-09-17 05:28    [W:4.160 / U:0.280 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site