lkml.org 
[lkml]   [2018]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.14 10/87] uwb: hwa-rc: fix memory leak at probe
    Date
    From: Anton Vasilyev <vasilyev@ispras.ru>

    [ Upstream commit 11b71782c1d10d9bccc31825cf84291cd7588a1e ]

    hwarc_probe() allocates memory for hwarc, but does not free it
    if uwb_rc_add() or hwarc_get_version() fail.

    Found by Linux Driver Verification project (linuxtesting.org).

    Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/uwb/hwa-rc.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/uwb/hwa-rc.c b/drivers/uwb/hwa-rc.c
    index 9a53912bdfe9..5d3ba747ae17 100644
    --- a/drivers/uwb/hwa-rc.c
    +++ b/drivers/uwb/hwa-rc.c
    @@ -873,6 +873,7 @@ static int hwarc_probe(struct usb_interface *iface,
    error_rc_add:
    usb_put_intf(iface);
    usb_put_dev(hwarc->usb_dev);
    + kfree(hwarc);
    error_alloc:
    uwb_rc_put(uwb_rc);
    error_rc_alloc:
    --
    2.17.1
    \
     
     \ /
      Last update: 2018-09-17 05:27    [W:4.111 / U:0.672 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site