lkml.org 
[lkml]   [2018]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 3.18 16/29] media: soc_camera: ov772x: correct setting of banding filter
    Date
    From: Akinobu Mita <akinobu.mita@gmail.com>

    [ Upstream commit 22216ec41e919682c15345e95928f266e8ba6f9e ]

    The banding filter ON/OFF is controlled via bit 5 of COM8 register. It
    is attempted to be enabled in ov772x_set_params() by the following line.

    ret = ov772x_mask_set(client, COM8, BNDF_ON_OFF, 1);

    But this unexpectedly results disabling the banding filter, because the
    mask and set bits are exclusive.

    On the other hand, ov772x_s_ctrl() correctly sets the bit by:

    ret = ov772x_mask_set(client, COM8, BNDF_ON_OFF, BNDF_ON_OFF);

    The same fix was already applied to non-soc_camera version of ov772x
    driver in the commit commit a024ee14cd36 ("media: ov772x: correct setting
    of banding filter")

    Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>
    Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    Cc: Hans Verkuil <hans.verkuil@cisco.com>
    Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
    Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/media/i2c/soc_camera/ov772x.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/media/i2c/soc_camera/ov772x.c b/drivers/media/i2c/soc_camera/ov772x.c
    index 970a04e1e56e..a08502766474 100644
    --- a/drivers/media/i2c/soc_camera/ov772x.c
    +++ b/drivers/media/i2c/soc_camera/ov772x.c
    @@ -834,7 +834,7 @@ static int ov772x_set_params(struct ov772x_priv *priv,
    * set COM8
    */
    if (priv->band_filter) {
    - ret = ov772x_mask_set(client, COM8, BNDF_ON_OFF, 1);
    + ret = ov772x_mask_set(client, COM8, BNDF_ON_OFF, BNDF_ON_OFF);
    if (!ret)
    ret = ov772x_mask_set(client, BDBASE,
    0xff, 256 - priv->band_filter);
    --
    2.17.1
    \
     
     \ /
      Last update: 2018-09-17 05:10    [W:4.185 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site