lkml.org 
[lkml]   [2018]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 3.18 24/29] HID: hid-ntrig: add error handling for sysfs_create_group
    Date
    From: Zhouyang Jia <jiazhouyang09@gmail.com>

    [ Upstream commit 44d4d51de9a3534a2b63d69efda02a10e66541e4 ]

    When sysfs_create_group fails, the lack of error-handling code may
    cause unexpected results.

    This patch adds error-handling code after calling sysfs_create_group.

    Signed-off-by: Zhouyang Jia <jiazhouyang09@gmail.com>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    ---
    drivers/hid/hid-ntrig.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/hid/hid-ntrig.c b/drivers/hid/hid-ntrig.c
    index 600f2075512f..dc497b633e28 100644
    --- a/drivers/hid/hid-ntrig.c
    +++ b/drivers/hid/hid-ntrig.c
    @@ -953,6 +953,8 @@ static int ntrig_probe(struct hid_device *hdev, const struct hid_device_id *id)

    ret = sysfs_create_group(&hdev->dev.kobj,
    &ntrig_attribute_group);
    + if (ret)
    + hid_err(hdev, "cannot create sysfs group\n");

    return 0;
    err_free:
    --
    2.17.1
    \
     
     \ /
      Last update: 2018-09-17 05:09    [W:2.396 / U:0.356 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site