Messages in this thread | | | Date | Mon, 17 Sep 2018 14:18:35 -0700 | From | Mark Brown <> | Subject | Re: [PATCH v2 4/4] spi: spi-davinci: Add support for SPI_CS_WORD |
| |
On Thu, Sep 13, 2018 at 09:26:48AM -0500, David Lechner wrote: > On 09/13/2018 08:44 AM, Geert Uytterhoeven wrote:
> I suppose it might be best to modify the SPI core to say:
> if ((spi->mode & SPI_CS_WORD) && (!(ctlr->mode_bits & SPI_CS_WORD) || > gpio_is_valid(spi->cs_gpio)) {
> instead of:
> if ((spi->mode & SPI_CS_WORD) && !(ctlr->mode_bits & SPI_CS_WORD)) {
> Then we could drop the error above.
Yes, that makes sense - the same thing is going to apply to any controller with this support. [unhandled content-type:application/pgp-signature] | |