lkml.org 
[lkml]   [2018]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] Drivers: hv: vmbus: include header for get_irq_regs()
Date
From Sebastian Andrzej Siewior   Sent: Thursday, August 30, 2018 12:55 AM
>
> On !RT the header file get_irq_regs() gets pulled in via other header files. On
> RT it does not and the build fails:
>
> drivers/hv/vmbus_drv.c:975 implicit declaration of function ‘get_irq_regs’ [-
> Werror=implicit-function-declaration]
> drivers/hv/hv.c:115 implicit declaration of function ‘get_irq_regs’ [-Werror=implicit-
> function-declaration]
>
> Add the header file for get_irq_regs() in a common header so it used by
> vmbus_drv.c by hv.c for their get_irq_regs() usage.
>

get_irq_regs() is not used explicitly in either vmbus_drv.c or in hv.c. And I
couldn't make the line numbers in the errors above line up with anything
in the source code that might be implicitly using get_irq_regs(). Is it the
calls to add_interrupt_randomness()? Did you figure out
exactly what line of code is causing the compile error?

I'm wondering whether adding the #include of irq.h into hyperv_vmbus.h
is really the right solution. More correct might be to have the file where
get_irq_regs() is actually used to #include irq_regs.h.

Michael
\
 
 \ /
  Last update: 2018-09-16 01:27    [W:0.123 / U:1.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site