Messages in this thread | | | From | (Eric W. Biederman) | Date | Sun, 16 Sep 2018 20:04:05 +0200 | Subject | [PATCH 0/4] signal: Cleanups |
| |
What follows are some small cleanups to signal handling functions that arose from my previous work on sorting out signals during fork.
There are two cases where I did not previously mark functions that sent signals to a group of processes. It was safe because they sent SIGKILL but it is still a good idea to mark that they send signals to a group of processes to be consistent.
After that I just have the trivial cleanups of removing specific_send_sig_info which confuses more than helps when I read the code, and moving the exports of signal functions next to their callers so that future cleanups are easier.
On my wish list is to continue this work and ensure all of the signal sending functions are being used correctly and to reduce the set of signal sending functions so that there is less confusion in how to use them.
I took a quick look at limiting force_sig to only the callers that use it to transmit a synchronous exception. Unfortunately I discovered that where there is one small bug there are others so those use cases need something more than a brainless mass conversion to fix.
So I am first going to focus on finishing on cleaning up the signal sending functions for exceptions that send siginfo. I have just a few architectures left and I just need to double check that I didn't do anything stupid and post those changes for review.
If anyone sees any issues with these patches let me know. Otherwise I am going to merge them into my siginfo tree.
Eric W. Biederman (4): tty_io: Use group_send_sig_info in __do_SACK to note it is a session being killed signal: Use group_send_sig_info to kill all processes in a pid namespace signal: Remove specific_send_sig_info signal: Pair exports with their functions
drivers/tty/tty_io.c | 6 +++--- kernel/pid_namespace.c | 2 +- kernel/signal.c | 25 +++++++++---------------- 3 files changed, 13 insertions(+), 20 deletions(-)
Eric
| |