Messages in this thread | | | Date | Sat, 15 Sep 2018 09:18:19 +0800 | From | zhong jiang <> | Subject | Re: [PATCH] sched: Fix a GCC compiled warning. |
| |
On 2018/9/15 0:43, Miguel Ojeda wrote: > Hi Zhong, > > On Fri, Sep 14, 2018 at 4:49 PM, zhong jiang <zhongjiang@huawei.com> wrote: >> Fix the following compile warning: >> >> kernel/sched/core.c: In function ‘update_rq_clock_task’: >> kernel/sched/core.c:139:6: warning: unused variable ‘steal’ [-Wunused-variable] >> s64 steal = 0, irq_delta = 0; >> > Dou (and I, without having noticed Dou's) also sent another patch for this, see: > > https://lore.kernel.org/patchwork/patch/973402/ > https://lore.kernel.org/patchwork/patch/983794/ Thank you for spoting this. I miss them.
Sincerely, zhong jiang > Cheers, > Miguel > >> Signed-off-by: zhong jiang <zhongjiang@huawei.com> >> --- >> kernel/sched/core.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/kernel/sched/core.c b/kernel/sched/core.c >> index 7577ce4..1003c1d 100644 >> --- a/kernel/sched/core.c >> +++ b/kernel/sched/core.c >> @@ -136,7 +136,7 @@ static void update_rq_clock_task(struct rq *rq, s64 delta) >> * to sched_rt_avg_update. But I don't trust it... >> */ >> #if defined(CONFIG_IRQ_TIME_ACCOUNTING) || defined(CONFIG_PARAVIRT_TIME_ACCOUNTING) >> - s64 steal = 0, irq_delta = 0; >> + s64 __maybe_unused steal = 0, irq_delta = 0; >> #endif >> #ifdef CONFIG_IRQ_TIME_ACCOUNTING >> irq_delta = irq_time_read(cpu_of(rq)) - rq->prev_irq_time; >> -- >> 1.7.12.4 >> >
| |