lkml.org 
[lkml]   [2018]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/5] remoteproc: Check for NULL firmwares in sysfs interface
    Date
    The remoteproc framework provides a sysfs file 'firmware'
    for modifying the firmware image name from userspace. Add
    an additional check to ensure NULL firmwares are errored
    out right away, rather than getting a delayed error while
    requesting a firmware during the start of a remoteproc
    later on.

    Signed-off-by: Suman Anna <s-anna@ti.com>
    ---
    drivers/remoteproc/remoteproc_sysfs.c | 5 +++++
    1 file changed, 5 insertions(+)

    diff --git a/drivers/remoteproc/remoteproc_sysfs.c b/drivers/remoteproc/remoteproc_sysfs.c
    index 2142b3ea726e..ce93f4d710f3 100644
    --- a/drivers/remoteproc/remoteproc_sysfs.c
    +++ b/drivers/remoteproc/remoteproc_sysfs.c
    @@ -49,6 +49,11 @@ static ssize_t firmware_store(struct device *dev,
    }

    len = strcspn(buf, "\n");
    + if (!len) {
    + dev_err(dev, "can't provide a NULL firmware\n");
    + err = -EINVAL;
    + goto out;
    + }

    p = kstrndup(buf, len, GFP_KERNEL);
    if (!p) {
    --
    2.18.0
    \
     
     \ /
      Last update: 2018-09-15 02:39    [W:2.975 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site