Messages in this thread | | | Date | Fri, 14 Sep 2018 16:29:23 +0200 | From | Miquel Raynal <> | Subject | Re: [PATCH] mtd: rawnand: denali: fix a race condition when DMA is kicked |
| |
Hello,
Masahiro Yamada <yamada.masahiro@socionext.com> wrote on Thu, 13 Sep 2018 14:58:49 +0900:
> I thought the read-back of the DMA_ENABLE register was unnecessary > (at least it is working on my boards), then deleted it in commit > 586a2c52909d ("mtd: nand: denali: squash denali_enable_dma() helper > into caller"). Sorry, I was wrong - it caused a timing issue on > Cyclone5 SoCFPGAs. > > Revive the register read-back, commenting why this is necessary. > > Fixes: 586a2c52909d ("mtd: nand: denali: squash denali_enable_dma() helper into caller") > Reported-by: Steffen Trumtrar <s.trumtrar@pengutronix.de> > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks, Miquèl
| |