Messages in this thread | | | Date | Fri, 14 Sep 2018 10:16:17 -0400 | From | Jerome Glisse <> | Subject | Re: [PATCH v5 5/7] mm, hmm: Use devm semantics for hmm_devmem_{add, remove} |
| |
On Fri, Sep 14, 2018 at 03:18:38PM +0200, Christoph Hellwig wrote: > On Wed, Sep 12, 2018 at 07:22:27PM -0700, Dan Williams wrote: > > devm semantics arrange for resources to be torn down when > > device-driver-probe fails or when device-driver-release completes. > > Similar to devm_memremap_pages() there is no need to support an explicit > > remove operation when the users properly adhere to devm semantics. > > > > Note that devm_kzalloc() automatically handles allocating node-local > > memory. > > > > Reviewed-by: Christoph Hellwig <hch@lst.de> > > Given that we have no single user of these function I still think we > should just remove them.
It is in the process of being upstreamed:
https://cgit.freedesktop.org/~glisse/linux/log/?h=nouveau-hmm-v01
and more users are coming for other devices.
Yes it is taking time ... things never goes as planed.
Cheers, Jérôme
| |