Messages in this thread Patch in this message | | | From | Quentin Schulz <> | Subject | [PATCH net-next 3/5] net: phy: mscc: remove unneeded parenthesis | Date | Fri, 14 Sep 2018 10:33:45 +0200 |
| |
The == operator precedes the || operator, so we can remove the parenthesis around (a == b) || (c == d).
The condition is rather explicit and short so removing the parenthesis definitely does not make it harder to read.
Signed-off-by: Quentin Schulz <quentin.schulz@bootlin.com> --- drivers/net/phy/mscc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/mscc.c b/drivers/net/phy/mscc.c index c0a9ea9..734d9fb 100644 --- a/drivers/net/phy/mscc.c +++ b/drivers/net/phy/mscc.c @@ -301,7 +301,7 @@ static int vsc85xx_mdix_set(struct phy_device *phydev, u8 mdix) u16 reg_val; reg_val = phy_read(phydev, MSCC_PHY_BYPASS_CONTROL); - if ((mdix == ETH_TP_MDI) || (mdix == ETH_TP_MDI_X)) { + if (mdix == ETH_TP_MDI || mdix == ETH_TP_MDI_X) { reg_val |= (DISABLE_PAIR_SWAP_CORR_MASK | DISABLE_POLARITY_CORR_MASK | DISABLE_HP_AUTO_MDIX_MASK); -- git-series 0.9.1
| |