lkml.org 
[lkml]   [2018]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.18 118/197] RDS: IB: fix passing zero to ERR_PTR() warning
    Date
    4.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: YueHaibing <yuehaibing@huawei.com>

    [ Upstream commit 5941923da29e84bc9e2a1abb2c14fffaf8d71e2f ]

    Fix a static code checker warning:
    net/rds/ib_frmr.c:82 rds_ib_alloc_frmr() warn: passing zero to 'ERR_PTR'

    The error path for ib_alloc_mr failure should set err to PTR_ERR.

    Fixes: 1659185fb4d0 ("RDS: IB: Support Fastreg MR (FRMR) memory registration mode")
    Signed-off-by: YueHaibing <yuehaibing@huawei.com>
    Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/rds/ib_frmr.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/net/rds/ib_frmr.c
    +++ b/net/rds/ib_frmr.c
    @@ -61,6 +61,7 @@ static struct rds_ib_mr *rds_ib_alloc_fr
    pool->fmr_attr.max_pages);
    if (IS_ERR(frmr->mr)) {
    pr_warn("RDS/IB: %s failed to allocate MR", __func__);
    + err = PTR_ERR(frmr->mr);
    goto out_no_cigar;
    }


    \
     
     \ /
      Last update: 2018-09-13 16:03    [W:4.069 / U:0.404 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site