lkml.org 
[lkml]   [2018]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.18 134/197] btrfs: replace: Reset on-disk dev stats value after replace
    Date
    4.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>

    [ Upstream commit 1e7e1f9e3aba00c9b9c323bfeeddafe69ff21ff6 ]

    on-disk devs stats value is updated in btrfs_run_dev_stats(),
    which is called during commit transaction, if device->dev_stats_ccnt
    is not zero.

    Since current replace operation does not touch dev_stats_ccnt,
    on-disk dev stats value is not updated. Therefore "btrfs device stats"
    may return old device's value after umount/mount
    (Example: See "btrfs ins dump-t -t DEV $DEV" after btrfs/100 finish).

    Fix this by just incrementing dev_stats_ccnt in
    btrfs_dev_replace_finishing() when replace is succeeded and this will
    update the values.

    Signed-off-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
    Reviewed-by: David Sterba <dsterba@suse.com>
    Signed-off-by: David Sterba <dsterba@suse.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    fs/btrfs/dev-replace.c | 6 ++++++
    1 file changed, 6 insertions(+)

    --- a/fs/btrfs/dev-replace.c
    +++ b/fs/btrfs/dev-replace.c
    @@ -677,6 +677,12 @@ static int btrfs_dev_replace_finishing(s
    btrfs_rm_dev_replace_unblocked(fs_info);

    /*
    + * Increment dev_stats_ccnt so that btrfs_run_dev_stats() will
    + * update on-disk dev stats value during commit transaction
    + */
    + atomic_inc(&tgt_device->dev_stats_ccnt);
    +
    + /*
    * this is again a consistent state where no dev_replace procedure
    * is running, the target device is part of the filesystem, the
    * source device is not part of the filesystem anymore and its 1st

    \
     
     \ /
      Last update: 2018-09-13 16:01    [W:2.435 / U:1.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site