lkml.org 
[lkml]   [2018]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.18 086/197] coccicheck: return proper error code on fail
    Date
    4.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Denis Efremov <efremov@linux.com>

    [ Upstream commit 512ddf7d7db056edfed3159ea7cb4e4a5eefddd4 ]

    If coccicheck fails, it should return an error code distinct from zero
    to signal about an internal problem. Current code instead of exiting with
    the tool's error code returns the error code of 'echo "coccicheck failed"'
    which is almost always equals to zero, thus failing the original intention
    of alerting about a problem. This patch fixes the code.

    Found by Linux Driver Verification project (linuxtesting.org).

    Signed-off-by: Denis Efremov <efremov@linux.com>
    Acked-by: Julia Lawall <julia.lawall@lip6.fr>
    Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    scripts/coccicheck | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    --- a/scripts/coccicheck
    +++ b/scripts/coccicheck
    @@ -128,9 +128,10 @@ run_cmd_parmap() {
    fi
    echo $@ >>$DEBUG_FILE
    $@ 2>>$DEBUG_FILE
    - if [[ $? -ne 0 ]]; then
    + err=$?
    + if [[ $err -ne 0 ]]; then
    echo "coccicheck failed"
    - exit $?
    + exit $err
    fi
    }


    \
     
     \ /
      Last update: 2018-09-13 15:57    [W:4.198 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site