lkml.org 
[lkml]   [2018]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 057/115] s390/dasd: fix hanging offline processing due to canceled worker
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Stefan Haberland <sth@linux.ibm.com>

    [ Upstream commit 669f3765b755fd8739ab46ce3a9c6292ce8b3d2a ]

    During offline processing two worker threads are canceled without
    freeing the device reference which leads to a hanging offline process.

    Reviewed-by: Jan Hoeppner <hoeppner@linux.ibm.com>
    Signed-off-by: Stefan Haberland <sth@linux.ibm.com>
    Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/s390/block/dasd_eckd.c | 7 +++++--
    1 file changed, 5 insertions(+), 2 deletions(-)

    --- a/drivers/s390/block/dasd_eckd.c
    +++ b/drivers/s390/block/dasd_eckd.c
    @@ -2032,8 +2032,11 @@ static int dasd_eckd_basic_to_ready(stru

    static int dasd_eckd_online_to_ready(struct dasd_device *device)
    {
    - cancel_work_sync(&device->reload_device);
    - cancel_work_sync(&device->kick_validate);
    + if (cancel_work_sync(&device->reload_device))
    + dasd_put_device(device);
    + if (cancel_work_sync(&device->kick_validate))
    + dasd_put_device(device);
    +
    return 0;
    };


    \
     
     \ /
      Last update: 2018-09-13 15:49    [W:4.205 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site