lkml.org 
[lkml]   [2018]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 33/78] RDMA/hns: Fix usage of bitmap allocation functions return values
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Gal Pressman <pressmangal@gmail.com>

    [ Upstream commit a1ceeca679dccc492235f0f629d9e9f7b3d51ca8 ]

    hns bitmap allocation functions return 0 on success and -1 on failure.
    Callers of these functions wrongly used their return value as an errno,
    fix that by making a proper conversion.

    Fixes: a598c6f4c5a8 ("IB/hns: Simplify function of pd alloc and qp alloc")
    Signed-off-by: Gal Pressman <pressmangal@gmail.com>
    Acked-by: Lijun Ou <oulijun@huawei.com>
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/infiniband/hw/hns/hns_roce_pd.c | 2 +-
    drivers/infiniband/hw/hns/hns_roce_qp.c | 5 ++++-
    2 files changed, 5 insertions(+), 2 deletions(-)

    --- a/drivers/infiniband/hw/hns/hns_roce_pd.c
    +++ b/drivers/infiniband/hw/hns/hns_roce_pd.c
    @@ -35,7 +35,7 @@

    static int hns_roce_pd_alloc(struct hns_roce_dev *hr_dev, unsigned long *pdn)
    {
    - return hns_roce_bitmap_alloc(&hr_dev->pd_bitmap, pdn);
    + return hns_roce_bitmap_alloc(&hr_dev->pd_bitmap, pdn) ? -ENOMEM : 0;
    }

    static void hns_roce_pd_free(struct hns_roce_dev *hr_dev, unsigned long pdn)
    --- a/drivers/infiniband/hw/hns/hns_roce_qp.c
    +++ b/drivers/infiniband/hw/hns/hns_roce_qp.c
    @@ -114,7 +114,10 @@ static int hns_roce_reserve_range_qp(str
    {
    struct hns_roce_qp_table *qp_table = &hr_dev->qp_table;

    - return hns_roce_bitmap_alloc_range(&qp_table->bitmap, cnt, align, base);
    + return hns_roce_bitmap_alloc_range(&qp_table->bitmap, cnt, align,
    + base) ?
    + -ENOMEM :
    + 0;
    }

    enum hns_roce_qp_state to_hns_roce_state(enum ib_qp_state state)

    \
     
     \ /
      Last update: 2018-09-13 15:40    [W:4.078 / U:0.884 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site