lkml.org 
[lkml]   [2018]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 02/78] act_ife: fix a potential use-after-free
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Cong Wang <xiyou.wangcong@gmail.com>

    [ Upstream commit 6d784f1625ea68783cc1fb17de8f6cd3e1660c3f ]

    Immediately after module_put(), user could delete this
    module, so e->ops could be already freed before we call
    e->ops->release().

    Fix this by moving module_put() after ops->release().

    Fixes: ef6980b6becb ("introduce IFE action")
    Cc: Jamal Hadi Salim <jhs@mojatatu.com>
    Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/sched/act_ife.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/sched/act_ife.c
    +++ b/net/sched/act_ife.c
    @@ -395,7 +395,6 @@ static void _tcf_ife_cleanup(struct tc_a
    struct tcf_meta_info *e, *n;

    list_for_each_entry_safe(e, n, &ife->metalist, metalist) {
    - module_put(e->ops->owner);
    list_del(&e->metalist);
    if (e->metaval) {
    if (e->ops->release)
    @@ -403,6 +402,7 @@ static void _tcf_ife_cleanup(struct tc_a
    else
    kfree(e->metaval);
    }
    + module_put(e->ops->owner);
    kfree(e);
    }
    }

    \
     
     \ /
      Last update: 2018-09-13 15:36    [W:2.676 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site