lkml.org 
[lkml]   [2018]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v3 1/5] drm/rockchip: prepare common code for cdns and rk dpi/dp driver
    From
    Date
    Hi Damian,

    Quite late but.

    On 28.08.2018 12:24, Damian Kos wrote:
    > - Extracted common fields from cdn_dp_device to a new cdns_mhdp_device
    > structure which will be used by two separate drivers later on.
    > - Moved some datatypes (audio_format, audio_info, vic_pxl_encoding_format,
    > video_info) from cdn-dp-core.c to cdn-dp-reg.h.
    > - Changed prefixes from cdn_dp to cdns_mhdp
    > cdn -> cdns to match the other Cadence's drivers
    > dp -> mhdp to distinguish it from a "just a DP" as the IP underneath
    > this registers map can be a HDMI (which is internally different,
    > but the interface for commands, events is pretty much the same).
    > - Modified cdn-dp-core.c to use the new driver structure and new function
    > names.
    >
    > Signed-off-by: Damian Kos <dkos@cadence.com>

    Many changes, hard to review. Anyway:

    Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>

     --
    Regards
    Andrzej


    \
     
     \ /
      Last update: 2018-09-13 12:01    [W:8.078 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site