lkml.org 
[lkml]   [2018]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH AUTOSEL 4.18 02/88] usb: usbtest: use irqsave() in USB's complete callback
    Date
    On Fri, Sep 07, 2018 at 07:42:23AM +0200, Greg Kroah-Hartman wrote:
    >On Fri, Sep 07, 2018 at 12:35:52AM +0000, Sasha Levin wrote:
    >> From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
    >>
    >> [ Upstream commit 6f3fde684d0232e66ada3410f016a58e09a87689 ]
    >>
    >> The USB completion callback does not disable interrupts while acquiring
    >> the lock. We want to remove the local_irq_disable() invocation from
    >> __usb_hcd_giveback_urb() and therefore it is required for the callback
    >> handler to disable the interrupts while acquiring the lock.
    >> The callback may be invoked either in IRQ or BH context depending on the
    >> USB host controller.
    >> Use the _irqsave() variant of the locking primitives.
    >
    >All of the "use irqsave in USB's complete callback" patches are not
    >stable material as they are prep work for changes that have yet to hit
    >Linus's tree.
    >
    >So you can drop this one.

    Now dropped. Thanks!
    \
     
     \ /
      Last update: 2018-09-12 19:39    [W:4.688 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site