| Subject | Re: [PATCH v5 05/27] arm64: Use daifflag_restore after bp_hardening | From | James Morse <> | Date | Wed, 12 Sep 2018 11:32:21 +0100 |
| |
Hi Julien,
On 28/08/18 16:51, Julien Thierry wrote: > For EL0 entries requiring bp_hardening, daif status is kept at > DAIF_PROCCTX_NOIRQ until after hardening has been done. Then interrupts > are enabled through local_irq_enable(). > > Before using local_irq_* functions, daifflags should be properly restored > to a state where IRQs are enabled.
> Enable IRQs by restoring DAIF_PROCCTX state after bp hardening.
Is this just for symmetry, or are you going on to add something to the daifflags state that local_irq_* functions won't change? (if so, could you allude to that in the commit message)
Either way,
Acked-by: James Morse <james.morse@arm.com>
|