lkml.org 
[lkml]   [2018]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 04/11] dts: qcom: Update coresight bindings for hardware ports
    Hi Suzuki,

    On Tue, Sep 11, 2018 at 11:17:05AM +0100, Suzuki K Poulose wrote:
    > Switch to updated coresight bindings for hw ports
    >
    > Cc: Andy Gross <andy.gross@linaro.org>
    > Cc: David Brown <david.brown@linaro.org>
    > Cc: Ivan T. Ivanov <ivan.ivanov@linaro.org>
    > Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
    > Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
    > ---
    > arch/arm64/boot/dts/qcom/msm8916.dtsi | 98 ++++++++++++++++++++++-------------
    > 1 file changed, 63 insertions(+), 35 deletions(-)
    >
    > diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
    > index 7b32b89..5bed52b 100644
    > --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
    > +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
    > @@ -1099,10 +1099,11 @@
    > clocks = <&rpmcc RPM_QDSS_CLK>, <&rpmcc RPM_QDSS_A_CLK>;
    > clock-names = "apb_pclk", "atclk";
    >
    > - port {
    > - tpiu_in: endpoint {
    > - slave-mode;
    > - remote-endpoint = <&replicator_out1>;
    > + out-ports {

    Here should be in-ports for tpiu node?

    BTW, if upper comment is valid, this means the DT binding doc also
    gives wrong example for tpiu node [1].

    I tested this patch with upper changing to 'in-ports', etm with perf
    mode can work well on DB410c board.

    [...]

    Thanks,
    Leo Yan

    [1] https://git.linaro.org/kernel/coresight.git/tree/Documentation/devicetree/bindings/arm/coresight.txt?h=next#n135

    \
     
     \ /
      Last update: 2018-09-12 12:19    [W:2.917 / U:0.416 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site