Messages in this thread Patch in this message | | | Date | Tue, 11 Sep 2018 23:52:58 -0700 | From | tip-bot for Masami Hiramatsu <> | Subject | [tip:perf/core] kprobes: Remove pointless BUG_ON() from reuse_unused_kprobe() |
| |
Commit-ID: a6d18e65dff2b73ceeb187c598b48898e36ad7b1 Gitweb: https://git.kernel.org/tip/a6d18e65dff2b73ceeb187c598b48898e36ad7b1 Author: Masami Hiramatsu <mhiramat@kernel.org> AuthorDate: Tue, 11 Sep 2018 19:20:11 +0900 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Wed, 12 Sep 2018 08:01:16 +0200
kprobes: Remove pointless BUG_ON() from reuse_unused_kprobe()
Since reuse_unused_kprobe() is called when the given kprobe is unused, checking it inside again with BUG_ON() is pointless. Remove it.
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org> Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com> Cc: David S . Miller <davem@davemloft.net> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Naveen N . Rao <naveen.n.rao@linux.vnet.ibm.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/153666121154.21306.17540752948574483565.stgit@devbox Signed-off-by: Ingo Molnar <mingo@kernel.org> --- kernel/kprobes.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/kernel/kprobes.c b/kernel/kprobes.c index 231569e1e2c8..277a6cbe83db 100644 --- a/kernel/kprobes.c +++ b/kernel/kprobes.c @@ -704,7 +704,6 @@ static void reuse_unused_kprobe(struct kprobe *ap) { struct optimized_kprobe *op; - BUG_ON(!kprobe_unused(ap)); /* * Unused kprobe MUST be on the way of delayed unoptimizing (means * there is still a relative jump) and disabled.
| |