Messages in this thread | | | Date | Tue, 11 Sep 2018 23:07:16 -0700 (PDT) | Subject | Re: [PATCH v2] ethernet: hnae: drop adhoc assert() macros | From | David Miller <> |
| |
From: Igor Stoppa <igor.stoppa@gmail.com> Date: Sat, 8 Sep 2018 18:01:42 +0300
> Replace assert() with a less misleading test_condition() using WARN() > Drop one check which had bitrotted and didn't compile anymore. > > Signed-off-by: Igor Stoppa <igor.stoppa@huawei.com>
I'm still kind of not happy about this.
Make the driver use kernel interfaces like WARN_ON_ONCE() etc. directly instead of defining alias CPP macros private to the driver.
If it needs to be conditional upon DEBUG, we have pr_debug() and the likes as well.
Thank you.
| |