[lkml]   [2018]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
SubjectRe: [PATCH] uio: fix is_source param for check_copy_size() in copy_to_iter_mcsafe()
On Wed, Sep 12, 2018 at 12:48 AM, Greg KH <> wrote:
> On Wed, Sep 05, 2018 at 01:31:40PM -0700, Dave Jiang wrote:
>> copy_to_iter_mcsafe() is passing in the is_source parameter as "false"
>> to check_copy_size(). This is different than what copy_to_iter() does.
>> Also, the addr parameter passed to check_copy_size() is the source so
>> therefore we should be passing in "true" instead.
>> Fixes: 8780356ef630 ("x86/asm/memcpy_mcsafe: Define copy_to_iter_mcsafe()")
>> Cc: Fan Du <>
>> Reported-by: Wenwei Tao <>
>> Signed-off-by: Dave Jiang <>
>> Reviewed-by: Vishal Verma <>
>> Cc: stable <>
>> ---
>> include/linux/uio.h | 2 +-
> I am not the maintainer of this file, sorry, please work with the -mm
> developers for this.

Likely this is's fault:

$ ./scripts/ -f include/linux/uio.h
Greg Kroah-Hartman <> (maintainer:USERSPACE I/O (UIO)) (open list)

Maybe a MAINTAINERS update like the following is warranted, because I
don't think -mm developers are right either, Al seems to be authority
on iov_iter apis:

index d870cb57c887..0018e19b4d8e 100644
@@ -15344,13 +15344,18 @@ F: arch/x86/um/
F: fs/hostfs/
F: fs/hppfs/

+USERSPACE ACCESS (uaccess, copy_{to,from}_iter)
+M: Alexander Viro <>
+S: Maintained
+F: include/linux/uio*.h
+F: lib/iov_iter.c
M: Greg Kroah-Hartman <>
S: Maintained
T: git git://
F: Documentation/driver-api/uio-howto.rst
F: drivers/uio/
-F: include/linux/uio*.h

M: Karel Zak <>
In any event, the patch in question is a trivial one liner, I feel
confident sending it along to Linus with some other pending fixes.

 \ /
  Last update: 2018-09-12 23:52    [W:0.047 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site