Messages in this thread | | | Date | Tue, 11 Sep 2018 08:49:59 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH] percpu-refcount: relax limit on percpu_ref_reinit() |
| |
On Tue, Sep 11, 2018 at 11:45:41PM +0800, Ming Lei wrote: > > So, this part seems wrong. The function is called percpu_ref_reinit() > > - the refcnt is expected to be in its initial state with just the base > > ref once this function returns. If you're removing the restriction on > > But the comment says that 'Re-initialize @ref so that it's in the same > state as when it finished', and this invariant isn't changed with this > patch.
The comment goes "when perpcu_ref_init() finished". The function is called re _init_. It should put the ref in the initial state, right?
Thanks.
-- tejun
| |