Messages in this thread | | | From | Laurent Pinchart <> | Subject | Re: [PATCH v2 05/13] udmabuf: constify udmabuf_create args | Date | Tue, 11 Sep 2018 17:53:06 +0300 |
| |
Hi Gerd,
Thank you for the patch.
On Tuesday, 11 September 2018 16:42:08 EEST Gerd Hoffmann wrote: > Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > drivers/dma-buf/udmabuf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c > index e3560e840d..4167da8141 100644 > --- a/drivers/dma-buf/udmabuf.c > +++ b/drivers/dma-buf/udmabuf.c > @@ -116,8 +116,8 @@ static const struct dma_buf_ops udmabuf_ops = { > #define SEALS_WANTED (F_SEAL_SHRINK) > #define SEALS_DENIED (F_SEAL_WRITE) > > -static long udmabuf_create(struct udmabuf_create_list *head, > - struct udmabuf_create_item *list) > +static long udmabuf_create(const struct udmabuf_create_list *head, > + const const struct udmabuf_create_item *list)
Even if you really want to make it const, a single const should suffice :-)
> { > DEFINE_DMA_BUF_EXPORT_INFO(exp_info); > struct file *memfd = NULL;
-- Regards,
Laurent Pinchart
| |