Messages in this thread Patch in this message | | | From | Laurent Pinchart <> | Subject | Re: [PATCH 06/10] udmabuf: add MEMFD_CREATE dependency | Date | Tue, 11 Sep 2018 12:40:10 +0300 |
| |
Hi Gerd,
Thank you for the patch.
On Tuesday, 11 September 2018 09:59:17 EEST Gerd Hoffmann wrote: > udmabuf builds without it, but if userspace can not create memfd > handles in the first place it is rather pointless to include it.
Except perhaps for compile test coverage ? How about
depends on MEMFD_CREATE || COMPILE_TEST
?
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > --- > drivers/dma-buf/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/dma-buf/Kconfig b/drivers/dma-buf/Kconfig > index 338129eb12..fc3fe3f04e 100644 > --- a/drivers/dma-buf/Kconfig > +++ b/drivers/dma-buf/Kconfig > @@ -34,6 +34,7 @@ config UDMABUF > bool "userspace dmabuf misc driver" > default n > depends on DMA_SHARED_BUFFER > + depends on MEMFD_CREATE > help > A driver to let userspace turn memfd regions into dma-bufs. > Qemu can use this to create host dmabufs for guest framebuffers.
-- Regards,
Laurent Pinchart
| |