Messages in this thread | | | Date | Tue, 11 Sep 2018 13:11:22 +0530 | From | Vinod <> | Subject | Re: [PATCH 3/3] dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer |
| |
On 07-09-18, 12:08, Radhey Shyam Pandey wrote:
> > > Yeah that part was clear but the implementation can be better.. > I thought over it and it seems having a new interface dma_ctrl_write_64 > taking lsb and msb bits input looks better and scalable. It will be similar > to existing vdma_desc_write_64 impl. I will send v2 if it looks ok.
Yes that is much better, btw why not reuse same routine as common xilinx lib functions :)
-- ~Vinod
| |