Messages in this thread | | | Date | Tue, 11 Sep 2018 09:38:44 +0200 | From | Daniel Vetter <> | Subject | Re: [PATCH 03/10] udmabuf: use pgoff_t for pagecount |
| |
On Tue, Sep 11, 2018 at 08:59:14AM +0200, Gerd Hoffmann wrote: > Reported-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
TIL pgoff_t stands for page cache offset. I think we're pretty bad at using that within i915 :-)
On the entire series Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
I did try to review in depth, but my brain is offline and coffee not working :-) Hence just an ack. -Daniel
> --- > drivers/dma-buf/udmabuf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c > index 19bd918209..ec22f203b5 100644 > --- a/drivers/dma-buf/udmabuf.c > +++ b/drivers/dma-buf/udmabuf.c > @@ -13,7 +13,7 @@ > #include <linux/udmabuf.h> > > struct udmabuf { > - u32 pagecount; > + pgoff_t pagecount; > struct page **pages; > }; > > -- > 2.9.3 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
-- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
| |