lkml.org 
[lkml]   [2018]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] sound: don't call skl_init_chip() to reset intel skl soc
On Mon, 10 Sep 2018 23:23:58 +0200,
Yu Zhao wrote:
>
> Internally, skl_init_chip() calls snd_hdac_bus_init_chip() which
> 1) sets bus->chip_init to prevent multiple entrances before device
> is stopped; 2) enables interrupt.
>
> We shouldn't use it for the purpose of resetting device only because
> 1) when we really want to initialize device, we won't be able to do
> so; 2) we are ready to handle interrupt yet, and kernel crashes when
> interrupt comes in.
>
> Rename azx_reset() to snd_hdac_bus_reset_link(), and use it to reset
> device properly.
>
> Fixes: 60767abcea3d ("ASoC: Intel: Skylake: Reset the controller in probe")
> Signed-off-by: Yu Zhao <yuzhao@google.com>

That makes sense.

And I noticed that the legacy HD-audio driver potentially needs the
same reset (although we haven't heard of any problem for years).

So now I wonder whether this requirement of reset is really mandatory
for the real hardware, or just theoretical...

In anyway,

Reviewed-by: Takashi Iwai <tiwai@suse.de>


thanks,

Takashi

\
 
 \ /
  Last update: 2018-09-11 08:17    [W:0.147 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site