lkml.org 
[lkml]   [2018]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] Revert "ASoC: Intel: Skylake: Acquire irq after RIRB allocation"
On Mon, 10 Sep 2018 23:17:18 +0200,
Yu Zhao wrote:
>
> This reverts commit 12eeeb4f4733bbc4481d01df35933fc15beb8b19.
>
> The patch doesn't fix accessing memory with null pointer in
> skl_interrupt().
>
> There are two problems: 1) skl_init_chip() is called twice, before
> and after dma buffer is allocate. The first call sets bus->chip_init
> which prevents the second from initializing bus->corb.buf and
> rirb.buf from bus->rb.area. 2) snd_hdac_bus_init_chip() enables
> interrupt before snd_hdac_bus_init_cmd_io() initializing dma buffers.
> There is a small window which skl_interrupt() can be called if irq
> has been acquired. If so, it crashes when using null dma buffer
> pointers.
>
> Will fix the problems in the following patches. Also attaching the
> crash for future reference.
>
> [ 16.949148] general protection fault: 0000 [#1] PREEMPT SMP KASAN PTI
> [ 16.950829] gsmi: Log Shutdown Reason 0x03
> [ 16.950830] Modules linked in: uvcvideo(+) videobuf2_vmalloc snd_soc_skl(+) videobuf2_memops videobuf2_v4l2 videobuf2_core snd_soc_skl_ipc snd_soc_sst_ipc snd_soc_sst_dsp snd_soc_acpi snd_hda_ext_core snd_hda_core snd_soc_max98357a acpi_als snd_soc_da7219 lzo lzo_compress zram snd_seq_dummy snd_seq snd_seq_device bridge stp llc ipt_MASQUERADE nf_nat_masquerade_ipv4 xt_mark fuse cfg80211 iio_trig_sysfs cros_ec_sensors cros_ec_sensors_ring cros_ec_sensors_core industrialio_triggered_buffer kfifo_buf industrialio smsc95xx usbnet mii joydev
> [ 16.950874] CPU: 0 PID: 1083 Comm: chrome Not tainted 4.14.64 #14
> [ 16.950875] Hardware name: Google Yorp/Yorp, BIOS Google_Yorp.10985.0.2018_08_20_1648 08/17/2018
> [ 16.950878] task: ffff88015b1c2b80 task.stack: ffff880155f30000
> [ 16.950887] RIP: 0010:snd_hdac_bus_update_rirb+0x19b/0x4cf [snd_hda_core]
> [ 16.950889] RSP: 0000:ffff88015c807c08 EFLAGS: 00010003
> [ 16.950891] RAX: 0000000000000101 RBX: 000000000000080c RCX: 1ffff10026822185
> [ 16.950893] RDX: dffffc0000000000 RSI: ffff88015b1c2b80 RDI: ffffc90000514058
> [ 16.950894] RBP: ffff88015c807c68 R08: 0000000000000000 R09: 0000000000000000
> [ 16.950895] R10: 0000000000000000 R11: ffffffffc043074f R12: 0000000000000800
> [ 16.950897] R13: 0000000000000001 R14: 0000000000000002 R15: 1ffff10026822119
> [ 16.950899] FS: 00007d85924cc740(0000) GS:ffff88015c800000(0000) knlGS:0000000000000000
> [ 16.950900] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 16.950902] CR2: 000058a54df16038 CR3: 00000001551c0000 CR4: 00000000003406f0
> [ 16.950903] Call Trace:
> [ 16.950906] <IRQ>
> [ 16.950918] skl_interrupt+0x19e/0x2d6 [snd_soc_skl]
> [ 16.950926] ? dma_supported+0xb5/0xb5 [snd_soc_skl]
> [ 16.950933] __handle_irq_event_percpu+0x27a/0x6c8
> [ 16.950937] ? __irq_wake_thread+0x1d1/0x1d1
> [ 16.950942] ? __do_softirq+0x57a/0x69e
> [ 16.950944] handle_irq_event_percpu+0x95/0x1ba
> [ 16.950948] ? _raw_spin_unlock+0x65/0xdc
> [ 16.950951] ? __handle_irq_event_percpu+0x6c8/0x6c8
> [ 16.950953] ? _raw_spin_unlock+0x65/0xdc
> [ 16.950957] ? time_cpufreq_notifier+0x483/0x483
> [ 16.950959] handle_irq_event+0x89/0x123
> [ 16.950962] handle_fasteoi_irq+0x16f/0x425
> [ 16.950965] handle_irq+0x1fe/0x28e
> [ 16.950969] do_IRQ+0x6e/0x12e
> [ 16.950972] common_interrupt+0x7a/0x7a
> [ 16.950974] </IRQ>
> [ 16.950976] RIP: 0033:0x58097f61a5c0
> [ 16.950978] RSP: 002b:00007ffe95c971a8 EFLAGS: 00000206 ORIG_RAX: ffffffffffffffbc
> [ 16.950980] RAX: 000058097f61a5c0 RBX: 00000e4ac5220560 RCX: 0000000000004e10
> [ 16.950982] RDX: 000058098563df20 RSI: 00007ffe95c97250 RDI: 00000e4ac5220500
> [ 16.950983] RBP: 00007ffe95c97410 R08: 0000000000000000 R09: 00007ffe95c97250
> [ 16.950984] R10: 0000000000000000 R11: 0000000000000000 R12: 00000e4ac5220560
> [ 16.950986] R13: 00000e4ac5220560 R14: 00000e4ac47c9650 R15: 0000580987646350
> [ 16.950988] Code: 74 12 48 89 df e8 eb 2d 8e cd 48 ba 00 00 00 00 00 fc ff df 4c 8b 23 44 89 f0 83 c8 01 0f b7 c0 49 8d 1c 84 48 89 d8 48 c1 e8 03 <8a> 04 10 84 c0 0f 85 da 01 00 00 44 8b 3b 41 0f b7 c6 49 8d 1c
> [ 16.951031] RIP: snd_hdac_bus_update_rirb+0x19b/0x4cf [snd_hda_core] RSP: ffff88015c807c08
> [ 16.951036] ---[ end trace 58bf9ece1775bc92 ]---
> [ 16.956871] Kernel panic - not syncing: Fatal exception in interrupt
> [ 16.956888] Kernel Offset: 0xc800000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff)

Please try to rip off uninteresting hex values and other stuff there.

> Signed-off-by: Yu Zhao <yuzhao@google.com>

Put Fixes tag.


thanks,

Takashi

\
 
 \ /
  Last update: 2018-09-11 08:04    [W:0.164 / U:0.980 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site