lkml.org 
[lkml]   [2018]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv3 2/6] tty/ldsem: Update waiter->task before waking up reader
On (09/11/18 14:04), Sergey Senozhatsky wrote:
> > for (;;) {
> > set_current_state(TASK_UNINTERRUPTIBLE);
>
> I think that set_current_state() also executes memory barrier. Just
> because it accesses task state.
>
> > - if (!waiter.task)
> > + if (!READ_ONCE(waiter.task))
> > break;
> > if (!timeout)
> > break;

This READ_ONCE(waiter.task) looks interesting. Maybe could be moved
to a loop condition

while (!READ_ONCE(waiter.task)) {
...
}

-ss

\
 
 \ /
  Last update: 2018-09-11 07:42    [W:0.063 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site