Messages in this thread | | | Subject | Re: [PATCH] arm64: dts: rockchip: add i2s and spdif endpoint of rk3328 | From | Katsuhiro Suzuki <> | Date | Tue, 11 Sep 2018 01:07:18 +0900 |
| |
Hi Heiko,
On 2018年09月10日 22:57, Heiko Stuebner wrote: > Hi, > > Am Donnerstag, 6. September 2018, 18:39:56 CEST schrieb Katsuhiro Suzuki: >> This patch adds port and endpoint of i2s and spdif nodes for rk3328. >> Because to use modern sound card interface such as audio-graph-card. >> >> Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net> >> --- >> arch/arm64/boot/dts/rockchip/rk3328.dtsi | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi >> index d3ef6566325e..41f0a20b73ed 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi >> @@ -179,7 +179,13 @@ >> clock-names = "i2s_clk", "i2s_hclk"; >> dmas = <&dmac 11>, <&dmac 12>; >> dma-names = "tx", "rx"; >> + #sound-dai-cells = <0>; >> status = "disabled"; >> + >> + i2s0_p0: port@0 { > > there is only one port per device, so this should probably be > i2s0_p0: port { > without the address. Same for all others. > The of-graph framework should work just fine then as well.
Thanks, indeed. I'll fix and send v2.
> > Heiko > > >
Regards, -- Katsuhiro Suzuki
| |