lkml.org 
[lkml]   [2018]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v6 2/5] x86/mm: fix sme_populate_pgd() to update page flags
    On Fri, Sep 07, 2018 at 12:57:27PM -0500, Brijesh Singh wrote:
    > Fix sme_populate_pgd() to update page flags if the PMD/PTE entry
    > already exists.
    >
    > Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
    > Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
    > Cc: Tom Lendacky <thomas.lendacky@amd.com>
    > Cc: kvm@vger.kernel.org
    > Cc: Thomas Gleixner <tglx@linutronix.de>
    > Cc: Borislav Petkov <bp@suse.de>
    > Cc: "H. Peter Anvin" <hpa@zytor.com>
    > Cc: linux-kernel@vger.kernel.org
    > Cc: Paolo Bonzini <pbonzini@redhat.com>
    > Cc: Sean Christopherson <sean.j.christopherson@intel.com>
    > Cc: kvm@vger.kernel.org
    > Cc: "Radim Krčmář" <rkrcmar@redhat.com>
    > ---
    > arch/x86/mm/mem_encrypt_identity.c | 6 +-----
    > 1 file changed, 1 insertion(+), 5 deletions(-)
    >
    > diff --git a/arch/x86/mm/mem_encrypt_identity.c b/arch/x86/mm/mem_encrypt_identity.c
    > index 92265d3..7659e65 100644
    > --- a/arch/x86/mm/mem_encrypt_identity.c
    > +++ b/arch/x86/mm/mem_encrypt_identity.c
    > @@ -154,9 +154,6 @@ static void __init sme_populate_pgd_large(struct sme_populate_pgd_data *ppd)
    > return;
    >
    > pmd = pmd_offset(pud, ppd->vaddr);
    > - if (pmd_large(*pmd))
    > - return;
    > -
    > set_pmd(pmd, __pmd(ppd->paddr | ppd->pmd_flags));
    > }
    >
    > @@ -182,8 +179,7 @@ static void __init sme_populate_pgd(struct sme_populate_pgd_data *ppd)
    > return;
    >
    > pte = pte_offset_map(pmd, ppd->vaddr);
    > - if (pte_none(*pte))
    > - set_pte(pte, __pte(ppd->paddr | ppd->pte_flags));
    > + set_pte(pte, __pte(ppd->paddr | ppd->pte_flags));
    > }
    >
    > static void __init __sme_map_range_pmd(struct sme_populate_pgd_data *ppd)
    > --

    This looks like a bugfix to me and as such should be:

    * at the beginning of the series
    * contain a Fixes: tag
    * contain Cc: <stable@vger.kernel.org>

    Right?

    With that addressed:

    Reviewed-by: Borislav Petkov <bp@suse.de>

    --
    Regards/Gruss,
    Boris.

    SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
    --

    \
     
     \ /
      Last update: 2018-09-10 13:37    [W:2.879 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site