lkml.org 
[lkml]   [2018]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 13/16] nvmem: add support for cell lookups from machine code
    On Mon, 10 Sep 2018 11:45:48 +0200
    Bartosz Golaszewski <brgl@bgdev.pl> wrote:

    > 2018-09-10 10:55 GMT+02:00 Srinivas Kandagatla <srinivas.kandagatla@linaro.org>:
    > >
    > >
    > > On 10/09/18 09:23, Boris Brezillon wrote:
    > >>
    > >> Well, if we get rid of nvmem-machine.h, the cell-lookup stuff
    > >> should go in nvmem-consumer.h not nvmem-provider.h. On the other hand,
    > >> everything that is related to cell creation should be placed in
    > >> nvmem-provider.h.
    > >
    > > Yes, this is how it should be!
    > >
    >
    > Any actual reason for not putting these definitions into a separate
    > 'machine' header? This approach is currently used by gpio, pinctrl,
    > iio and regulator framework because most systems use either DT or ACPI
    > and don't need to pull in any stuff aimed at board files.

    I'm perfectly fine with the separate header file, all I'm saying is, if
    Srinivas does not want nvmem-machine.h, definitions should be placed in
    nvmem-provider.h or nvmem-consumer.h depending on who they're meant to
    be used by (providers or consumers).

    \
     
     \ /
      Last update: 2018-09-10 11:51    [W:3.058 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site