Messages in this thread | | | Subject | Re: [PATCH] wireless: remove unnecessary condition check before kfree | From | Johannes Berg <> | Date | Mon, 10 Sep 2018 09:10:06 +0200 |
| |
On Sat, 2018-09-08 at 22:12 +0800, zhong jiang wrote: > kfree has taken the null pointer into account. Just remove the > redundant condition check before kfree.
I'm all for doing that if it actually removes conditionals, but
> - if (!IS_ERR_OR_NULL(regdb)) > + if (!IS_ERR(regdb)) > kfree(regdb);
this seems rather pointless since there's still a condition. In that case, I feel it's easier to understand the original code.
johannes
| |