lkml.org 
[lkml]   [2018]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] platform/x86: dell-smbios-wmi: Correct a memory leak
On Mon, Sep 10, 2018 at 01:01:52PM -0500, Mario Limonciello wrote:
> ACPI buffers were being allocated but never freed.
>
> Reported-by: Pinzhen Xu <pinzhen.xu@intel.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
> Cc: stable@vger.kernel.org

Thanks Mario and Pinzhen, both queued. That's an easy one to miss, the usage not
being particularly obvious.

> ---
> drivers/platform/x86/dell-smbios-wmi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/dell-smbios-wmi.c b/drivers/platform/x86/dell-smbios-wmi.c
> index 88afe56..cf2229e 100644
> --- a/drivers/platform/x86/dell-smbios-wmi.c
> +++ b/drivers/platform/x86/dell-smbios-wmi.c
> @@ -78,6 +78,7 @@ static int run_smbios_call(struct wmi_device *wdev)
> dev_dbg(&wdev->dev, "result: [%08x,%08x,%08x,%08x]\n",
> priv->buf->std.output[0], priv->buf->std.output[1],
> priv->buf->std.output[2], priv->buf->std.output[3]);
> + kfree(output.pointer);
>
> return 0;
> }
> --
> 2.7.4
>
>

--
Darren Hart
VMware Open Source Technology Center

\
 
 \ /
  Last update: 2018-09-10 22:52    [W:0.068 / U:0.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site