Messages in this thread | | | From | Miguel Ojeda <> | Date | Sat, 1 Sep 2018 14:58:44 +0200 | Subject | Re: [PATCH 7/7] Compiler Attributes: use feature checks instead of version checks |
| |
Hi Luc,
On Sat, Sep 1, 2018 at 11:56 AM, Luc Van Oostenryck <luc.vanoostenryck@gmail.com> wrote: > > For sparse (which doesn't support __has_attribute() yet and defines > __GNUC_MINOR__ depending on the compiler used to build it) it won't > be totally correct since the concerned attributes here will be > incorrectly considered as not supported. But, since these attributes > have no semantic effects for sparse, it won't matter. > > So, for sparse: > Reviewed-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Thanks for checking (and for the sparse patches too!). I will note this in the commit message for v3.
Cheers, Miguel
| |