lkml.org 
[lkml]   [2018]   [Sep]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 7/7] Compiler Attributes: use feature checks instead of version checks
    Hi Luc,

    On Sat, Sep 1, 2018 at 11:56 AM, Luc Van Oostenryck
    <luc.vanoostenryck@gmail.com> wrote:
    >
    > For sparse (which doesn't support __has_attribute() yet and defines
    > __GNUC_MINOR__ depending on the compiler used to build it) it won't
    > be totally correct since the concerned attributes here will be
    > incorrectly considered as not supported. But, since these attributes
    > have no semantic effects for sparse, it won't matter.
    >
    > So, for sparse:
    > Reviewed-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>

    Thanks for checking (and for the sparse patches too!). I will note
    this in the commit message for v3.

    Cheers,
    Miguel

    \
     
     \ /
      Last update: 2018-09-01 14:59    [W:6.533 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site