Messages in this thread | | | Subject | Re: [PATCH v2 2/2] i2c: npcm7xx: add i2c controller master mode only | From | Andy Shevchenko <> | Date | Tue, 07 Aug 2018 14:26:25 +0300 |
| |
On Tue, 2018-08-07 at 14:07 +0300, Tali Perry wrote: > Nuvoton NPCM7XX I2C Controller > NPCM7xx includes 16 I2C contollers. THis driver operates the > controller. > This module also includes a slave mode, which will be submitted later > on. > > Any feedback would be appreciated. > > v2 -> v1: > - run check patch in strict mode. > - use linux crc. > - define regs in constant offset without base. > - remove debug prints. > - no declerations for local functions. > > v1: initial version
I don't know / remember why I'm in Cc list here, but you can go through my other reviews and find style recommendations for your code as well.
-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
| |