Messages in this thread | | | From | Joel Fernandes <> | Date | Mon, 6 Aug 2018 17:43:19 -0700 | Subject | Re: [PATCH v12 3/3] tracing: Centralize preemptirq tracepoints and unify their usage |
| |
On Mon, Aug 6, 2018 at 12:50 PM, Steven Rostedt <rostedt@goodmis.org> wrote: > > With this patch applied, I'm constantly getting lockdep errors. Instead > of doing a full revert of the patch, I did this, which makes all those > errors go away. I may apply this for now, and we can revisit having > lockdep use the tracepoint code. But since it's currently always > enabled, I'm thinking of just leaving this as is. The macros are still > clean from Joel's patch. > > Thoughts?
I like your patch. Thanks a lot for doing this.. It keeps most of the benefits of my patch while avoiding the issues with lockdep. I agree we can look at the remaining lockdep issue after. There were several lockdep issues with this patch that I fixed over the the months, but there's still the one that Masami reported that I believe you're also seeing. Once I'm back I'll work on figuring that one out.
Could you pull in the fixes to the other issues I posted though? With that we should be good. https://lore.kernel.org/patchwork/patch/971104/ https://lore.kernel.org/patchwork/patch/971829/
thanks,
- Joel
| |