Messages in this thread | | | Subject | Re: RISC-V: Don't use a global include guard for uapi/asm/syscalls.h | Date | Mon, 6 Aug 2018 13:42:57 -0700 | From | Palmer Dabbelt <> |
| |
On Sat, 04 Aug 2018 01:54:38 PDT (-0700), Christoph Hellwig wrote: >> index 818655b0d535..882a6aa09a33 100644 >> --- a/arch/riscv/include/uapi/asm/syscalls.h >> +++ b/arch/riscv/include/uapi/asm/syscalls.h >> @@ -1,10 +1,11 @@ >> -/* SPDX-License-Identifier: GPL-2.0 */ >> +// SPDX-License-Identifier: GPL-2.0 > > /* */ is the required style for headers, // is only for other files. > >> +/* There is explicitly no include guard here because this file is expected to >> + * be included multiple times in order to define the syscall macros via >> + * __SYSCALL. */ > > Normal Linux comment style would be: > > /* > * There is explicitly no include guard here because this file is expected to > * be included multiple times in order to define the syscall macros via > * __SYSCALL. > */ > > Also syscalls.h isn't included directly anywhere, but through > <asm/unistd.h>, so we'll probably need a similar comment there as well.
I've attached a v2 with both of these fixed. Thanks!
| |