Messages in this thread | | | Date | Mon, 6 Aug 2018 16:26:25 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 19/20] perf annotate: Add --percent-type option |
| |
On Mon, Aug 06, 2018 at 10:49:12PM +0900, Namhyung Kim wrote: > On Sat, Aug 04, 2018 at 03:05:20PM +0200, Jiri Olsa wrote: > > Adding --percent-type option to set annotation percent type > > from following choices: > > global-period, local-period, global-hits, local-hits > > > > Examples: > > $ perf annotate --percent-type period-local --stdio | head -1 > > Percent | Source code ... es, percent: local period) > > $ perf annotate --percent-type hits-local --stdio | head -1 > > Percent | Source code ... es, percent: local hits) > > $ perf annotate --percent-type hits-global --stdio | head -1 > > Percent | Source code ... es, percent: global hits) > > $ perf annotate --percent-type period-global --stdio | head -1 > > Percent | Source code ... es, percent: global period) > > > > The local/global keywords set if the percentage is computed > > in the scope of the function (local) or the whole data (global). > > > > The period/hits keywords set the base the percentage is computed > > on - the samples period or the number of samples (hits). > > What about adding "period" as an alias to "local-period" (and same for > "hits" as well)?
I dont mind that.. will add to v2 if there are no objections
thanks, jirka
| |