Messages in this thread |  | | Subject | Re: [PATCH v2 04/18] MIPS: dts: Add initial support for Intel MIPS SoCs | From | Hua Ma <> | Date | Mon, 6 Aug 2018 17:20:37 +0800 |
| |
On 8/4/2018 7:11 PM, Hauke Mehrtens wrote: > On 08/03/2018 05:02 AM, Songjun Wu wrote: >> From: Hua Ma <hua.ma@linux.intel.com> >> >> Add dts files to support Intel MIPS SoCs: >> - xrx500.dtsi is the chip dts >> - easy350_anywan.dts is the board dts >> >> Signed-off-by: Hua Ma <hua.ma@linux.intel.com> >> Signed-off-by: Songjun Wu <songjun.wu@linux.intel.com> >> --- >> >> Changes in v2: >> - New patch split from previous patch >> - The memory address is changed to @20000000 >> - Update to obj-$(CONFIG_BUILTIN_DTB) as per commit fca3aa166422 >> >> arch/mips/boot/dts/Makefile | 1 + >> arch/mips/boot/dts/intel-mips/Makefile | 4 ++ >> arch/mips/boot/dts/intel-mips/easy350_anywan.dts | 26 ++++++++++ >> arch/mips/boot/dts/intel-mips/xrx500.dtsi | 66 ++++++++++++++++++++++++ >> 4 files changed, 97 insertions(+) >> create mode 100644 arch/mips/boot/dts/intel-mips/Makefile >> create mode 100644 arch/mips/boot/dts/intel-mips/easy350_anywan.dts >> create mode 100644 arch/mips/boot/dts/intel-mips/xrx500.dtsi >> >> diff --git a/arch/mips/boot/dts/intel-mips/easy350_anywan.dts b/arch/mips/boot/dts/intel-mips/easy350_anywan.dts >> new file mode 100644 >> index 000000000000..e5e95f90c5e7 >> --- /dev/null >> +++ b/arch/mips/boot/dts/intel-mips/easy350_anywan.dts >> @@ -0,0 +1,26 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/dts-v1/; >> + >> +#include <dt-bindings/interrupt-controller/mips-gic.h> >> +#include <dt-bindings/clock/intel,grx500-clk.h> >> + >> +#include "xrx500.dtsi" >> + >> +/ { >> + model = "EASY350 ANYWAN (GRX350) Main model"; > Main model can be removed, it does not identify the board. Thanks, will remove.
>> + compatible = "intel,easy350-anywan"; > I think this should be > compatible = "intel,easy350-anywan", "intel,xrx500"; > > Are there different revisions of the EASY350 Anywan board or only of the > EASY550 board?There are at least some differences in the power supply on > the EASY550 V1 and EASY550 V2 board. I would suggest to be here very > specific to make it easier when adding more boards. OK, thanks.
>> + >> + aliases { >> + serial0 = &asc0; >> + }; >> + >> + chosen { >> + bootargs = "earlycon=lantiq,0x16600000 clk_ignore_unused"; > What happens when you remove clk_ignore_unused? > If it crashes we should probably define some of the clock to be always > active. OK, will check and improve if possible.
|  |