Messages in this thread | | | Date | Sun, 5 Aug 2018 16:22:39 +0200 | From | Greg KH <> | Subject | Re: [PATCH 6/7] staging:rtl8192u: Remove unused member variable - Style |
| |
On Sat, Aug 04, 2018 at 10:18:58AM +0100, John Whitmore wrote: > Remove name of 'reserved' bitfield member which is simply used to pad > the bitfield to a byte boundary. The actual bit has been left in place > so alignment should not change. The name, which is not required has > been removed. > > This is a coding style change which should have no impact on runtime > code execution. > > Signed-off-by: John Whitmore <johnfwhitmore@gmail.com> > --- > drivers/staging/rtl8192u/ieee80211/ieee80211.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging/rtl8192u/ieee80211/ieee80211.h > index 3cfeac0d7214..fc449806dab8 100644 > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211.h > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211.h > @@ -114,7 +114,7 @@ struct cb_desc { > u8 bBroadcast:1; > //u8 reserved2:2; > u8 drv_agg_enable:1; > - u8 reserved2:1; > + u8:1;
No, this is ok, and a common thing to do. Anonymous bit fields is not a normal thing.
thanks,
greg k-h
| |