lkml.org 
[lkml]   [2018]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ssb: driver_gige: use true and false for boolean values
On Sat, 4 Aug 2018 19:04:53 -0500
"Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:

> Return statements in functions returning bool should use true or false
> instead of an integer value.
>
> This code was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/ssb/driver_gige.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ssb/driver_gige.c b/drivers/ssb/driver_gige.c
> index e973405..ebee6b0 100644
> --- a/drivers/ssb/driver_gige.c
> +++ b/drivers/ssb/driver_gige.c
> @@ -242,7 +242,7 @@ static int ssb_gige_probe(struct ssb_device *sdev,
> bool pdev_is_ssb_gige_core(struct pci_dev *pdev)
> {
> if (!pdev->resource[0].name)
> - return 0;
> + return false;
> return (strcmp(pdev->resource[0].name, SSB_GIGE_MEM_RES_NAME) == 0);
> }
> EXPORT_SYMBOL(pdev_is_ssb_gige_core);

Looks good. Thanks.

Reviewed-by: Michael Buesch <m@bues.ch>


--
Michael
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-08-05 10:16    [W:0.509 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site