Messages in this thread | | | Date | Fri, 31 Aug 2018 18:51:04 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 1/4] x86/cpu: Introduce INTEL_CPU_FAM*_NODATA() helper macros |
| |
On Fri, Aug 31, 2018 at 08:41:28AM -0700, Andi Kleen wrote: > Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes: > > + > > +#define INTEL_CPU_FAM_ANY_NODATA(_family, _model) \ > > + INTEL_CPU_FAM_ANY(_family, _model, NULL) > > + > > +#define INTEL_CPU_FAM6_NODATA(_model) \ > > + INTEL_CPU_FAM_ANY_NODATA(6, INTEL_FAM6_##_model)
> _NODATA is actually longer than passing NULL ?
One character longer (you have to compare to ", NULL").
> Seems unnecessary
Let's gather other's opinions.
P.S. In any case some refactoring is needed to allow NULL in parameters (move & out from base macro).
-- With Best Regards, Andy Shevchenko
| |