Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Fri, 31 Aug 2018 14:37:39 +0200 | Subject | Re: [PATCH] regulator: da9063: fix DT probing with constraints |
| |
Hi Philipp,
On Fri, Aug 31, 2018 at 2:34 PM Philipp Zabel <p.zabel@pengutronix.de> wrote: > Commit 1c892e38ce59 ("regulator: da9063: Handle less LDOs on DA9063L") > reordered the da9063_regulator_info[] array, but not the DA9063_ID_* > regulator ids and not the da9063_matches[] array, because ids are used > as indices in the array initializer. This mismatch between regulator id > and da9063_regulator_info[] array index causes the driver probe to fail > because constraints from DT are not applied to the correct regulator: > > da9063 0-0058: Device detected (chip-ID: 0x61, var-ID: 0x50) > DA9063_BMEM: Bringing 900000uV into 3300000-3300000uV > DA9063_LDO9: Bringing 3300000uV into 2500000-2500000uV > DA9063_LDO1: Bringing 900000uV into 3300000-3300000uV > DA9063_LDO1: failed to apply 3300000-3300000uV constraint(-22)
My apologies for failing to notice that.
> This patch reorders the DA9063_ID_* as apparently intended, and with > them the entries in the da90630_matches[] array. > > Fixes: 1c892e38ce59 ("regulator: da9063: Handle less LDOs on DA9063L") > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |