lkml.org 
[lkml]   [2018]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/2] soc: qcom: geni: Don't ignore clk_round_rate() errors in geni_se_clk_tbl_get()
    Date
    The function clk_round_rate() is defined to return a "long", not an
    "unsigned long". That's because it might return a negative error
    code. Change the call in geni_se_clk_tbl_get() to check for errors.

    NOTE: overall the idea that we should iterate over clk_round_rate() to
    try to reconstruct a table already present in the clock driver is
    questionable. Specifically:
    - This method relies on "clk_round_rate()" rounding up.
    - This method only works if the table is sorted and has no duplicates.
    ...this patch doesn't try to fix those problems, it just makes the
    error handling more correct.

    Fixes: eddac5af0654 ("soc: qcom: Add GENI based QUP Wrapper driver")
    Signed-off-by: Douglas Anderson <dianders@chromium.org>
    ---

    drivers/soc/qcom/qcom-geni-se.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c
    index feed3db21c10..1b19b8428c4a 100644
    --- a/drivers/soc/qcom/qcom-geni-se.c
    +++ b/drivers/soc/qcom/qcom-geni-se.c
    @@ -513,7 +513,7 @@ EXPORT_SYMBOL(geni_se_resources_on);
    */
    int geni_se_clk_tbl_get(struct geni_se *se, unsigned long **tbl)
    {
    - unsigned long freq = 0;
    + long freq = 0;
    int i;

    if (se->clk_perf_tbl) {
    @@ -529,7 +529,7 @@ int geni_se_clk_tbl_get(struct geni_se *se, unsigned long **tbl)

    for (i = 0; i < MAX_CLK_PERF_LEVEL; i++) {
    freq = clk_round_rate(se->clk, freq + 1);
    - if (!freq || freq == se->clk_perf_tbl[i - 1])
    + if (freq <= 0 || freq == se->clk_perf_tbl[i - 1])
    break;
    se->clk_perf_tbl[i] = freq;
    }
    --
    2.19.0.rc0.228.g281dcd1b4d0-goog
    \
     
     \ /
      Last update: 2018-08-30 20:38    [W:3.189 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site